[ChatTemplate] Fix chat template for Gemma when answer is contained within question.
#9462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9462 +/- ##
===========================================
+ Coverage 52.70% 53.03% +0.32%
===========================================
Files 677 679 +2
Lines 109391 109626 +235
===========================================
+ Hits 57658 58137 +479
+ Misses 51733 51489 -244 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
DrownFish19
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Fix chat template for Gemma when answer is contained within question:
split_positions.split_positionsaccording to<start_of_turn>. (The last<start_of_turn>beforesplit_positionmust be immediately followed bymodel. )non_learnable_partsaccording tofiltered_positions.This PR is related to #9444